phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] phoenix issue #315: PHOENIX-3655 Global Phoenix Client Metrics for PQS
Date Thu, 02 Aug 2018 18:33:08 GMT
Github user joshelser commented on the issue:

    https://github.com/apache/phoenix/pull/315
  
    > Am I missing something here?
    
    Nope, it's me :). I didn't realize that the Factory was creating a new `Configuration`
every time. The setup of `GlobalClientMetrics` just... doesn't give us any way to do this
nicely :(
    
    I'm not sure what it takes to write a custom Factory (I think I did it once in an IT),
but would be OK if you defer this.
    
    After you commit this, please update the website with these necessary changes (e.g. at
least tell people that PQS exports metrics).


---

Mime
View raw message