phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] phoenix issue #315: PHOENIX-3655 Global Phoenix Client Metrics for PQS
Date Wed, 01 Aug 2018 15:36:17 GMT
Github user joshelser commented on the issue:

    https://github.com/apache/phoenix/pull/315
  
    > I think the only question pending in this PR is if we want JVMMetrics or not, which
are crucial from PQS POV, otherwise not really for a regular client.
    
    Agreed. What about just making a new configuration key in QueryServices/QueryServicesOptions
for including JVM metrics in client-metrics which defaults to `false`? Then, have PQS always
set this to be `true` via code.
    
    Going to pull this down right now and look at it too out of curiosity.


---

Mime
View raw message