From dev-return-53098-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Wed Jul 18 18:40:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id CD812180636 for ; Wed, 18 Jul 2018 18:40:03 +0200 (CEST) Received: (qmail 18626 invoked by uid 500); 18 Jul 2018 16:40:02 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 18606 invoked by uid 99); 18 Jul 2018 16:40:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Jul 2018 16:40:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id EACC4CAE4B for ; Wed, 18 Jul 2018 16:40:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id YGhkTU0lW_u9 for ; Wed, 18 Jul 2018 16:40:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id EE07E5F178 for ; Wed, 18 Jul 2018 16:40:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 90BEEE0361 for ; Wed, 18 Jul 2018 16:40:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4FFFF2713C for ; Wed, 18 Jul 2018 16:40:00 +0000 (UTC) Date: Wed, 18 Jul 2018 16:40:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-4817) Phoenix Tracing Web Application MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-4817?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 548053#comment-16548053 ]=20 ASF GitHub Bot commented on PHOENIX-4817: ----------------------------------------- Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/311#discussion_r203446437 =20 --- Diff: phoenix-tracing-webapp/src/main/java/org/apache/phoenix/traci= ngwebapp/http/Main.java --- @@ -62,15 +63,18 @@ public int run(String[] arg0) throws Exception { final String home =3D getConf().get(TRACE_SERVER_HTTP_JETTY_HO= ME_KEY, DEFAULT_HTTP_HOME); //setting up the embedded server - ProtectionDomain domain =3D Main.class.getProtectionDomain(); - URL location =3D domain.getCodeSource().getLocation(); - String webappDirLocation =3D location.toString().split("target= ")[0] +"src/main/webapp"; + String webappDirLocation =3D DEFAULT_WEBAPP_DIR_LOCATION; --- End diff -- =20 Suggest dropping `webappDirLocation` and just using `DEFAULT_WEBAPP_DIR= _LOCATION` since this is not configurable anyways. > Phoenix Tracing Web Application > ------------------------------- > > Key: PHOENIX-4817 > URL: https://issues.apache.org/jira/browse/PHOENIX-4817 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.14.0, 4.13.1 > Environment: maven 3+, JDK7 > Reporter: Vitaliy > Priority: Minor > Labels: patch > > # Phoenix Tracing Web Application can not be started, because traceserver= .py=C2=A0does not contain required dependencies. > # The path to the folder webapp is incorrectly specified, so=C2=A0Phoeni= x Tracing Web Application can not find this folder. > # Phoenix Tracing Web Application does not check null value=C2=A0where i= t is needed, so=C2=A0the application can not load List, Dependency Tree and= Features. > # Phoenix Tracing Web Application=C2=A0creates a query with the wrong ta= ble column names. > # Phoenix Tracing Web Application has only the default tracing-table nam= e (SYSTEM.TRACING_STATS) and=C2=A0does not get=C2=A0tracing-table name via = hbase-site.xml. -- This message was sent by Atlassian JIRA (v7.6.3#76005)