From dev-return-53388-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Sat Jul 28 23:23:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DBEB8180677 for ; Sat, 28 Jul 2018 23:23:04 +0200 (CEST) Received: (qmail 63451 invoked by uid 500); 28 Jul 2018 21:23:03 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 63296 invoked by uid 99); 28 Jul 2018 21:23:03 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 28 Jul 2018 21:23:03 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id AE8D5DFA6C; Sat, 28 Jul 2018 21:23:02 +0000 (UTC) From: twdsilva To: dev@phoenix.apache.org Reply-To: dev@phoenix.apache.org References: In-Reply-To: Subject: [GitHub] phoenix pull request #317: PHOENIX-3547 Supporting more number of indices pe... Content-Type: text/plain Message-Id: <20180728212302.AE8D5DFA6C@git1-us-west.apache.org> Date: Sat, 28 Jul 2018 21:23:02 +0000 (UTC) Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/317#discussion_r205952450 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java --- @@ -2185,7 +2223,7 @@ public void createTable(RpcController controller, CreateTableRequest request, throw sqlExceptions[0]; } long seqValue = seqValues[0]; - if (seqValue > Short.MAX_VALUE) { + if (seqValue > Long.MAX_VALUE) { --- End diff -- This check is no longer needed since the indexId is now a Long. When you call incrementSequences if the current sequence value is LONG.MAX_VALUE you will get an exception. ---