phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4817) Phoenix Tracing Web Application
Date Wed, 18 Jul 2018 16:40:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548053#comment-16548053
] 

ASF GitHub Bot commented on PHOENIX-4817:
-----------------------------------------

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/311#discussion_r203446437
  
    --- Diff: phoenix-tracing-webapp/src/main/java/org/apache/phoenix/tracingwebapp/http/Main.java
---
    @@ -62,15 +63,18 @@ public int run(String[] arg0) throws Exception {
             final String home = getConf().get(TRACE_SERVER_HTTP_JETTY_HOME_KEY,
                     DEFAULT_HTTP_HOME);
             //setting up the embedded server
    -        ProtectionDomain domain = Main.class.getProtectionDomain();
    -        URL location = domain.getCodeSource().getLocation();
    -        String webappDirLocation = location.toString().split("target")[0] +"src/main/webapp";
    +        String webappDirLocation = DEFAULT_WEBAPP_DIR_LOCATION;
    --- End diff --
    
    Suggest dropping `webappDirLocation` and just using `DEFAULT_WEBAPP_DIR_LOCATION` since
this is not configurable anyways.


> Phoenix Tracing Web Application
> -------------------------------
>
>                 Key: PHOENIX-4817
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4817
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.14.0, 4.13.1
>         Environment: maven 3+, JDK7
>            Reporter: Vitaliy
>            Priority: Minor
>              Labels: patch
>
> # Phoenix Tracing Web Application can not be started, because traceserver.py does not
contain required dependencies.
>  # The path to the folder webapp is incorrectly specified, so Phoenix Tracing Web Application
can not find this folder.
>  # Phoenix Tracing Web Application does not check null value where it is needed, so the
application can not load List, Dependency Tree and Features.
>  # Phoenix Tracing Web Application creates a query with the wrong table column names.
>  # Phoenix Tracing Web Application has only the default tracing-table name (SYSTEM.TRACING_STATS)
and does not get tracing-table name via hbase-site.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message