phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3655) Metrics for PQS
Date Tue, 24 Jul 2018 21:46:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554836#comment-16554836
] 

Josh Elser commented on PHOENIX-3655:
-------------------------------------

Part 1 is spot-on.

For part2, I would copy HBaseMetrics2HadoopMetricsAdapter (this was actually copied from [https://github.com/joshelser/dropwizard-hadoop-metrics2)|https://github.com/joshelser/dropwizard-hadoop-metrics2),]
into Phoenix. I think you would want to create your own "entry point" for Phoenix rather than
re-use GlobalMetricRegistriesAdapter – this has more HBase-isms that Phoenix needs. Inside
your wrapper, you would make sure that we register with the DefaultMetricsSystem. I imagine
you have an idea of the lifecycle of what parts of Phoenix you want to emit metrics for –
having a wrapper explicitly tied to that is a good idea.

I think in short you can summarize my suggestions as: use classes from hbase-metrics-api and
hbase-metrics, avoid or copy classes in hbase-hadoop2-compat in Phoenix. If a class you're
looking at has InterfaceAudience.Private, we likely don't want to use that in Phoenix.

Thanks for taking the time to write this up!

> Metrics for PQS
> ---------------
>
>                 Key: PHOENIX-3655
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3655
>             Project: Phoenix
>          Issue Type: New Feature
>    Affects Versions: 4.8.0
>         Environment: Linux 3.13.0-107-generic kernel, v4.9.0-HBase-0.98
>            Reporter: Rahul Shrivastava
>            Assignee: Karan Mehta
>            Priority: Major
>             Fix For: 4.15.0
>
>         Attachments: MetricsforPhoenixQueryServerPQS.pdf
>
>   Original Estimate: 240h
>  Remaining Estimate: 240h
>
> Phoenix Query Server runs a separate process compared to its thin client. Metrics collection
is currently done by PhoenixRuntime.java i.e. at Phoenix driver level. We need the following
> 1. For every jdbc statement/prepared statement/ run by PQS , we need capability to collect
metrics at PQS level and push the data to external sink i.e. file, JMX , other external custom
sources. 
> 2. Besides this global metrics could be periodically collected and pushed to the sink.

> 2. PQS can be configured to turn on metrics collection and type of collect ( runtime
or global) via hbase-site.xml
> 3. Sink could be configured via an interface in hbase-site.xml. 
> All metrics definition https://phoenix.apache.org/metrics.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message