phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3534) Support multi region SYSTEM.CATALOG table
Date Wed, 04 Jul 2018 23:20:04 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533120#comment-16533120
] 

ASF GitHub Bot commented on PHOENIX-3534:
-----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/303#discussion_r200208160
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/TableProperty.java ---
    @@ -231,36 +231,26 @@ public Object getPTableValue(PTable table) {
         private final SQLExceptionCode mutatingImmutablePropException;
         private final boolean isValidOnView;
         private final boolean isMutableOnView;
    -    private final boolean propagateToViews;
     
         private TableProperty(String propertyName, boolean isMutable, boolean isValidOnView,
boolean isMutableOnView) {
    -        this(propertyName, COLUMN_FAMILY_NOT_ALLOWED_TABLE_PROPERTY, isMutable, CANNOT_ALTER_PROPERTY,
isValidOnView, isMutableOnView, true);
    -    }
    -
    -    private TableProperty(String propertyName, boolean isMutable, boolean isValidOnView,
boolean isMutableOnView, boolean propagateToViews) {
    -        this(propertyName, COLUMN_FAMILY_NOT_ALLOWED_TABLE_PROPERTY, isMutable, CANNOT_ALTER_PROPERTY,
isValidOnView, isMutableOnView, propagateToViews);
    +        this(propertyName, COLUMN_FAMILY_NOT_ALLOWED_TABLE_PROPERTY, isMutable, CANNOT_ALTER_PROPERTY,
isValidOnView, isMutableOnView);
         }
     
         private TableProperty(String propertyName, SQLExceptionCode colFamilySpecifiedException,
boolean isMutable, boolean isValidOnView, boolean isMutableOnView) {
    -        this(propertyName, colFamilySpecifiedException, isMutable, CANNOT_ALTER_PROPERTY,
isValidOnView, isMutableOnView, true);
    +        this(propertyName, colFamilySpecifiedException, isMutable, CANNOT_ALTER_PROPERTY,
isValidOnView, isMutableOnView);
         }
     
         private TableProperty(String propertyName, boolean isMutable, boolean isValidOnView,
boolean isMutableOnView, SQLExceptionCode isMutatingException) {
    -        this(propertyName, COLUMN_FAMILY_NOT_ALLOWED_TABLE_PROPERTY, isMutable, isMutatingException,
isValidOnView, isMutableOnView, true);
    +        this(propertyName, COLUMN_FAMILY_NOT_ALLOWED_TABLE_PROPERTY, isMutable, isMutatingException,
isValidOnView, isMutableOnView);
         }
     
         private TableProperty(String propertyName, SQLExceptionCode colFamSpecifiedException,
boolean isMutable, SQLExceptionCode mutatingException, boolean isValidOnView, boolean isMutableOnView)
{
    -        this(propertyName, colFamSpecifiedException, isMutable, mutatingException, isValidOnView,
isMutableOnView, true);
    -    }
    -
    -    private TableProperty(String propertyName, SQLExceptionCode colFamSpecifiedException,
boolean isMutable, SQLExceptionCode mutatingException, boolean isValidOnView, boolean isMutableOnView,
boolean propagateToViews) {
    --- End diff --
    
    How did you end up dealing with table property conflicts between parent and children?
Is there follow up work required? Can we use the timestamp of the Cell storing the property
to differentiate similar to the logic for columns? It's fine to do this work in a follow up
JIRA.


> Support multi region SYSTEM.CATALOG table
> -----------------------------------------
>
>                 Key: PHOENIX-3534
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3534
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Thomas D'Silva
>            Priority: Major
>             Fix For: 5.0.0, 4.15.0
>
>         Attachments: PHOENIX-3534.patch
>
>
> Currently Phoenix requires that the SYSTEM.CATALOG table is single region based on the
server-side row locks being held for operations that impact a table and all of it's views.
For example, adding/removing a column from a base table pushes this change to all views.
> As an alternative to making the SYSTEM.CATALOG transactional (PHOENIX-2431), when a new
table is created we can do a lazy cleanup  of any rows that may be left over from a failed
DDL call (kudos to [~lhofhansl] for coming up with this idea). To implement this efficiently,
we'd need to also do PHOENIX-2051 so that we can efficiently find derived views.
> The implementation would rely on an optimistic concurrency model based on checking our
sequence numbers for each table/view before/after updating. Each table/view row would be individually
locked for their change (metadata for a view or table cannot span regions due to our split
policy), with the sequence number being incremented under lock and then returned to the client.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message