phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-3534) Support multi region SYSTEM.CATALOG table
Date Wed, 04 Jul 2018 23:20:03 GMT


ASF GitHub Bot commented on PHOENIX-3534:

Github user JamesRTaylor commented on a diff in the pull request:
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/ ---
    @@ -1957,6 +1968,17 @@ private PTable createTableInternal(CreateTableStatement statement,
byte[][] spli
                     linkStatement.setLong(6, parent.getSequenceNumber());
                     linkStatement.setString(7, PTableType.INDEX.getSerializedValue());
    +                // Add row linking index table to parent table for indexes on views
    +                if (parent.getType() == PTableType.VIEW) {
    +	                linkStatement = connection.prepareStatement(CREATE_VIEW_INDEX_PARENT_LINK);
    +	                linkStatement.setString(1, tenantIdStr);
    +	                linkStatement.setString(2, schemaName);
    +	                linkStatement.setString(3, tableName);
    +	                linkStatement.setString(4, parent.getName().getString());
    +	                linkStatement.setByte(5, LinkType.VIEW_INDEX_PARENT_TABLE.getSerializedValue());
    +	                linkStatement.execute();
    +                }
    --- End diff --
    We need to update MetaDataClient.createTableInternal() to not include the columns from
the parent table in 4.15 so that we can remove the code in MetaDataEndPointImpl that filters
the columns. It's fine to do this in a follow up JIRA, but we should remember to do it.

> Support multi region SYSTEM.CATALOG table
> -----------------------------------------
>                 Key: PHOENIX-3534
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Thomas D'Silva
>            Priority: Major
>             Fix For: 5.0.0, 4.15.0
>         Attachments: PHOENIX-3534.patch
> Currently Phoenix requires that the SYSTEM.CATALOG table is single region based on the
server-side row locks being held for operations that impact a table and all of it's views.
For example, adding/removing a column from a base table pushes this change to all views.
> As an alternative to making the SYSTEM.CATALOG transactional (PHOENIX-2431), when a new
table is created we can do a lazy cleanup  of any rows that may be left over from a failed
DDL call (kudos to [~lhofhansl] for coming up with this idea). To implement this efficiently,
we'd need to also do PHOENIX-2051 so that we can efficiently find derived views.
> The implementation would rely on an optimistic concurrency model based on checking our
sequence numbers for each table/view before/after updating. Each table/view row would be individually
locked for their change (metadata for a view or table cannot span regions due to our split
policy), with the sequence number being incremented under lock and then returned to the client.

This message was sent by Atlassian JIRA

View raw message