phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3534) Support multi region SYSTEM.CATALOG table
Date Wed, 11 Jul 2018 15:49:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540272#comment-16540272
] 

ASF GitHub Bot commented on PHOENIX-3534:
-----------------------------------------

Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/303#discussion_r201744675
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
    @@ -2573,307 +2897,139 @@ else if (pkCount <= COLUMN_NAME_INDEX
                     return new MetaDataMutationResult(MutationCode.UNALLOWED_TABLE_MUTATION,
EnvironmentEdgeManager.currentTimeMillis(), basePhysicalTable);
                 }
                 
    -            ColumnOrdinalPositionUpdateList ordinalPositionList = new ColumnOrdinalPositionUpdateList();
    +            //add the new columns to the child view
                 List<PColumn> viewPkCols = new ArrayList<>(view.getPKColumns());
                 boolean addingExistingPkCol = false;
    -            int numCols = view.getColumns().size();
    -            // add the new columns to the child view
    -            for (PutWithOrdinalPosition p : columnPutsForBaseTable) {
    -                Put baseTableColumnPut = p.put;
    +            for (Put columnToBeAdded : columnPutsForBaseTable) {
                     PColumn existingViewColumn = null;
                     byte[][] rkmd = new byte[5][];
    -                getVarChars(baseTableColumnPut.getRow(), rkmd);
    +                getVarChars(columnToBeAdded.getRow(), rkmd);
                     String columnName = Bytes.toString(rkmd[COLUMN_NAME_INDEX]);
    -                String columnFamily = rkmd[FAMILY_NAME_INDEX] == null ? null : Bytes.toString(rkmd[FAMILY_NAME_INDEX]);
    +                String columnFamily =
    +                        rkmd[FAMILY_NAME_INDEX] == null ? null
    +                                : Bytes.toString(rkmd[FAMILY_NAME_INDEX]);
                     try {
    -                    existingViewColumn = columnFamily == null ? view.getColumnForColumnName(columnName)
: view.getColumnFamily(
    -                            columnFamily).getPColumnForColumnName(columnName);
    +                    existingViewColumn =
    +                            columnFamily == null ? view.getColumnForColumnName(columnName)
    +                                    : view.getColumnFamily(columnFamily)
    +                                            .getPColumnForColumnName(columnName);
                     } catch (ColumnFamilyNotFoundException e) {
    -                    // ignore since it means that the column family is not present for
the column to be added.
    +                    // ignore since it means that the column family is not present for
the column to
    +                    // be added.
                     } catch (ColumnNotFoundException e) {
                         // ignore since it means the column is not present in the view
                     }
    -                
    -                boolean isPkCol = columnFamily == null;
    -                byte[] columnKey = getColumnKey(viewKey, columnName, columnFamily);
    +
    +                boolean isColumnToBeAddPkCol = columnFamily == null;
                     if (existingViewColumn != null) {
    -                    MetaDataMutationResult result = validateColumnForAddToBaseTable(existingViewColumn,
baseTableColumnPut, basePhysicalTable, isPkCol, view);
    -                    if (result != null) {
    -                        return result;
    +                    if (EncodedColumnsUtil.usesEncodedColumnNames(basePhysicalTable)
    +                            && !SchemaUtil.isPKColumn(existingViewColumn)) {
    --- End diff --
    
    The race condition with adding the same column to the base table and a child view will
be covered in PHOENIX-4799.


> Support multi region SYSTEM.CATALOG table
> -----------------------------------------
>
>                 Key: PHOENIX-3534
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3534
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Thomas D'Silva
>            Priority: Major
>             Fix For: 5.0.0, 4.15.0
>
>         Attachments: PHOENIX-3534.patch
>
>
> Currently Phoenix requires that the SYSTEM.CATALOG table is single region based on the
server-side row locks being held for operations that impact a table and all of it's views.
For example, adding/removing a column from a base table pushes this change to all views.
> As an alternative to making the SYSTEM.CATALOG transactional (PHOENIX-2431), when a new
table is created we can do a lazy cleanup  of any rows that may be left over from a failed
DDL call (kudos to [~lhofhansl] for coming up with this idea). To implement this efficiently,
we'd need to also do PHOENIX-2051 so that we can efficiently find derived views.
> The implementation would rely on an optimistic concurrency model based on checking our
sequence numbers for each table/view before/after updating. Each table/view row would be individually
locked for their change (metadata for a view or table cannot span regions due to our split
policy), with the sequence number being incremented under lock and then returned to the client.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message