phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3383) Comparison between descending row keys used in RVC is reverse
Date Wed, 04 Jul 2018 17:12:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532966#comment-16532966
] 

James Taylor commented on PHOENIX-3383:
---------------------------------------

[~tdsilva] - please review. This patch reworks the way in which we AND together expressions
to form the start/stop row of scans. Changes include:
 * handling RVCs more generally rather than having a min/max range separate from the compiled
slot constraints. Previously, we would not be able to compile an RVC unless it lead with the
leading PK column.
 * correctly interpreting comparison expressions with RVC that include PK columns in DESC
order. Previously the comparison operator had to be switched to it's opposite because of incorrect
processing.
 * more comments and unit tests

> Comparison between descending row keys used in RVC is reverse
> -------------------------------------------------------------
>
>                 Key: PHOENIX-3383
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3383
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>            Priority: Major
>              Labels: DESC
>             Fix For: 4.15.0
>
>         Attachments: PHOENIX-3383-wip1.patch, PHOENIX-3383-wip5.patch, PHOENIX-3383-wip6.patch,
PHOENIX-3383-wip7.patch, PHOENIX-3383_v1.patch, PHOENIX-3383_wip.patch, PHOENIX-3383_wip2.patch,
PHOENIX-3383_wip3.patch
>
>
> See PHOENIX-3382, but the comparison for RVC with descending row key columns is the reverse
of what it should be.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message