phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karanmehta93 <...@git.apache.org>
Subject [GitHub] phoenix pull request #313: PHOENIX-4799 Write cells using checkAndMutate to ...
Date Tue, 31 Jul 2018 07:05:36 GMT
Github user karanmehta93 commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/313#discussion_r206414686
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
    @@ -3410,17 +3405,10 @@ void ensureSystemTablesMigratedToSystemNamespace()
                 // No tables exist matching "SYSTEM\..*", they are all already in "SYSTEM:.*"
                 if (tableNames.size() == 0) { return; }
                 // Try to move any remaining tables matching "SYSTEM\..*" into "SYSTEM:"
    -            if (tableNames.size() > 5) {
    +            if (tableNames.size() > 7) {
                     logger.warn("Expected 5 system tables but found " + tableNames.size()
+ ":" + tableNames);
    --- End diff --
    
    nit: change log message appropriately. Extract the constant to a variable


---

Mime
View raw message