phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twdsilva <...@git.apache.org>
Subject [GitHub] phoenix pull request #317: PHOENIX-3547 Supporting more number of indices pe...
Date Sat, 28 Jul 2018 21:23:02 GMT
Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/317#discussion_r205952450
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
    @@ -2185,7 +2223,7 @@ public void createTable(RpcController controller, CreateTableRequest
request,
                                 throw sqlExceptions[0];
                             }
                             long seqValue = seqValues[0];
    -                        if (seqValue > Short.MAX_VALUE) {
    +                        if (seqValue > Long.MAX_VALUE) {
    --- End diff --
    
    This check is no longer needed since the indexId is now a Long. When you call incrementSequences
if the current sequence value is LONG.MAX_VALUE you will get an exception.


---

Mime
View raw message