phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] phoenix pull request #315: PHOENIX-3655 Global Phoenix Client Metrics for PQ...
Date Fri, 27 Jul 2018 20:03:45 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/315#discussion_r205884608
  
    --- Diff: phoenix-core/src/test/resources/hadoop-metrics2.properties ---
    @@ -32,10 +32,9 @@
     #    [prefix].[source|sink].[instance].[options]
     # See javadoc of package-info.java for org.apache.hadoop.metrics2 for detail
     
    -
    -# Don't attempt to start jmx mbeans for all sources.
    -#  For right now, all metrics are exported to a phoenix table
    -*.source.start_mbeans=false
    +hbase.source.start_mbeans=true
    +hbase.sink.sink0.class=org.apache.phoenix.monitoring.GlobalPhoenixMetricsTestSink
    --- End diff --
    
    Can you leave a comment in the test that this configuration is here? Otherwise, might
seem like voodoo


---

Mime
View raw message