phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request #308: Client-side hash aggregation
Date Thu, 19 Jul 2018 21:47:32 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/308#discussion_r203882988
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ClientHashSizeException.java
---
    @@ -0,0 +1,33 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.phoenix.iterate;
    +
    +/**
    + * Thrown by {@link org.apache.phoenix.iterate.ClientHashAggregatingResultIterator }
when
    + * hash size exceeds memory threshold.
    + * 
    + */
    +public class ClientHashSizeException extends RuntimeException {
    --- End diff --
    
    You won't need this as an InsufficientMemoryException will be thrown if you go above the
specified memory limit (based on existing Phoenix config properties) and this will be unwound
to become a SQLException with the code SQLExceptionCode.INSUFFICIENT_MEMORY.


---

Mime
View raw message