phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] phoenix pull request #311: PHOENIX-4817 Fixed Phoenix Tracing Web Applicatio...
Date Wed, 18 Jul 2018 16:39:35 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/311#discussion_r203446437
  
    --- Diff: phoenix-tracing-webapp/src/main/java/org/apache/phoenix/tracingwebapp/http/Main.java
---
    @@ -62,15 +63,18 @@ public int run(String[] arg0) throws Exception {
             final String home = getConf().get(TRACE_SERVER_HTTP_JETTY_HOME_KEY,
                     DEFAULT_HTTP_HOME);
             //setting up the embedded server
    -        ProtectionDomain domain = Main.class.getProtectionDomain();
    -        URL location = domain.getCodeSource().getLocation();
    -        String webappDirLocation = location.toString().split("target")[0] +"src/main/webapp";
    +        String webappDirLocation = DEFAULT_WEBAPP_DIR_LOCATION;
    --- End diff --
    
    Suggest dropping `webappDirLocation` and just using `DEFAULT_WEBAPP_DIR_LOCATION` since
this is not configurable anyways.


---

Mime
View raw message