phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] phoenix pull request #311: PHOENIX-4817 Fixed Phoenix Tracing Web Applicatio...
Date Wed, 18 Jul 2018 16:39:35 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/311#discussion_r203445596
  
    --- Diff: bin/traceserver.py ---
    @@ -116,8 +116,10 @@
     
     #    " -Xdebug -Xrunjdwp:transport=dt_socket,address=5005,server=y,suspend=n " + \
     #    " -XX:+UnlockCommercialFeatures -XX:+FlightRecorder -XX:FlightRecorderOptions=defaultrecording=true,dumponexit=true"
+ \
    -java_cmd = '%(java)s $PHOENIX_OPTS ' + \
    -    '-cp ' + hbase_config_path + os.pathsep + phoenix_utils.phoenix_traceserver_jar +
os.pathsep + phoenix_utils.phoenix_client_jar + \
    +java_cmd = '%(java)s  ' + \
    --- End diff --
    
    Seems like `$PHOENIX_OPTS` was dropped. Was this not being interpolated correctly? Is
this environment variable propagated into the traceserver java process?


---

Mime
View raw message