phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twdsilva <...@git.apache.org>
Subject [GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...
Date Wed, 11 Jul 2018 17:24:30 GMT
Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/303#discussion_r201776174
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
    @@ -1488,20 +1904,19 @@ public void createTable(RpcController controller, CreateTableRequest
request,
                 if (tableType == PTableType.VIEW) {
                     byte[][] parentSchemaTableNames = new byte[3][];
                     byte[][] parentPhysicalSchemaTableNames = new byte[3][];
    -                /*
    -                 * For a view, we lock the base physical table row. For a mapped view,
there is 
    -                 * no link present to the physical table. So the viewPhysicalTableRow
is null
    -                 * in that case.
    -                 */
    +				/*
    +				 * For a mapped view, there is no link present to the physical table. So the
    +				 * viewPhysicalTableRow is null in that case.
    +				 */
    --- End diff --
    
    Fixed.


---

Mime
View raw message