phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] phoenix pull request #307: PHOENIX-4688 Kerberize python phoenixdb
Date Tue, 10 Jul 2018 16:54:05 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/307#discussion_r201077800
  
    --- Diff: python/phoenixdb-module/phoenixdb/__init__.py ---
    @@ -1,11 +1,10 @@
    -# Licensed to the Apache Software Foundation (ASF) under one or more
    -# contributor license agreements.  See the NOTICE file distributed with
    -# this work for additional information regarding copyright ownership.
    -# The ASF licenses this file to You under the Apache License, Version 2.0
    -# (the "License"); you may not use this file except in compliance with
    -# the License.  You may obtain a copy of the License at
    +# Copyright 2015 Lukas Lalinsky
    --- End diff --
    
    Any reason for the re-add of this? We don't need this after the IP Clearance process,
I think. NOTICE file should be sufficient.


---

Mime
View raw message