phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...
Date Wed, 04 Jul 2018 23:19:57 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/303#discussion_r200208160
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/TableProperty.java ---
    @@ -231,36 +231,26 @@ public Object getPTableValue(PTable table) {
         private final SQLExceptionCode mutatingImmutablePropException;
         private final boolean isValidOnView;
         private final boolean isMutableOnView;
    -    private final boolean propagateToViews;
     
         private TableProperty(String propertyName, boolean isMutable, boolean isValidOnView,
boolean isMutableOnView) {
    -        this(propertyName, COLUMN_FAMILY_NOT_ALLOWED_TABLE_PROPERTY, isMutable, CANNOT_ALTER_PROPERTY,
isValidOnView, isMutableOnView, true);
    -    }
    -
    -    private TableProperty(String propertyName, boolean isMutable, boolean isValidOnView,
boolean isMutableOnView, boolean propagateToViews) {
    -        this(propertyName, COLUMN_FAMILY_NOT_ALLOWED_TABLE_PROPERTY, isMutable, CANNOT_ALTER_PROPERTY,
isValidOnView, isMutableOnView, propagateToViews);
    +        this(propertyName, COLUMN_FAMILY_NOT_ALLOWED_TABLE_PROPERTY, isMutable, CANNOT_ALTER_PROPERTY,
isValidOnView, isMutableOnView);
         }
     
         private TableProperty(String propertyName, SQLExceptionCode colFamilySpecifiedException,
boolean isMutable, boolean isValidOnView, boolean isMutableOnView) {
    -        this(propertyName, colFamilySpecifiedException, isMutable, CANNOT_ALTER_PROPERTY,
isValidOnView, isMutableOnView, true);
    +        this(propertyName, colFamilySpecifiedException, isMutable, CANNOT_ALTER_PROPERTY,
isValidOnView, isMutableOnView);
         }
     
         private TableProperty(String propertyName, boolean isMutable, boolean isValidOnView,
boolean isMutableOnView, SQLExceptionCode isMutatingException) {
    -        this(propertyName, COLUMN_FAMILY_NOT_ALLOWED_TABLE_PROPERTY, isMutable, isMutatingException,
isValidOnView, isMutableOnView, true);
    +        this(propertyName, COLUMN_FAMILY_NOT_ALLOWED_TABLE_PROPERTY, isMutable, isMutatingException,
isValidOnView, isMutableOnView);
         }
     
         private TableProperty(String propertyName, SQLExceptionCode colFamSpecifiedException,
boolean isMutable, SQLExceptionCode mutatingException, boolean isValidOnView, boolean isMutableOnView)
{
    -        this(propertyName, colFamSpecifiedException, isMutable, mutatingException, isValidOnView,
isMutableOnView, true);
    -    }
    -
    -    private TableProperty(String propertyName, SQLExceptionCode colFamSpecifiedException,
boolean isMutable, SQLExceptionCode mutatingException, boolean isValidOnView, boolean isMutableOnView,
boolean propagateToViews) {
    --- End diff --
    
    How did you end up dealing with table property conflicts between parent and children?
Is there follow up work required? Can we use the timestamp of the Cell storing the property
to differentiate similar to the logic for columns? It's fine to do this work in a follow up
JIRA.


---

Mime
View raw message