phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...
Date Wed, 04 Jul 2018 23:19:57 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/303#discussion_r200209126
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIT.java ---
    @@ -372,6 +378,31 @@ public void testViewAndTableAndDrop() throws Exception {
             // drop table cascade should succeed
             conn.createStatement().execute("DROP TABLE " + fullTableName + " CASCADE");
             
    +        validateViewDoesNotExist(conn, fullViewName1);
    +        validateViewDoesNotExist(conn, fullViewName2);
    +
    +    }
    +    
    +    @Test
    +    public void testRecreateDroppedTableWithChildViews() throws Exception {
    --- End diff --
    
    These new tests are good. These are testing that the left over metadata doesn't impact
the re-creation of a table since we don't make the RPC to delete views when a base table is
dropped, right? Do you think there'd be any issues if part of the rows for a view were there
(i.e. say that the create view failed, but some of the rows were written)? Might be good to
have a test like this - you could set it up by using HBase APIs to manually delete some rows
of a view.


---

Mime
View raw message