phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...
Date Wed, 04 Jul 2018 23:19:37 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/303#discussion_r200207100
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
    @@ -2147,46 +2566,29 @@ private MetaDataMutationResult doDropTable(byte[] key, byte[]
tenantId, byte[] s
                 }
     
                 if (tableType == PTableType.TABLE || tableType == PTableType.SYSTEM) {
    -                // Handle any child views that exist
    -                TableViewFinder tableViewFinderResult = findChildViews(region, tenantId,
table, clientVersion, !isCascade);
    -                if (tableViewFinderResult.hasViews()) {
    -                    if (isCascade) {
    -                        if (tableViewFinderResult.allViewsInMultipleRegions()) {
    -                            // We don't yet support deleting a table with views where
SYSTEM.CATALOG has split and the
    -                            // view metadata spans multiple regions
    -                            return new MetaDataMutationResult(MutationCode.UNALLOWED_TABLE_MUTATION,
    -                                    EnvironmentEdgeManager.currentTimeMillis(), null);
    -                        } else if (tableViewFinderResult.allViewsInSingleRegion()) {
    -                            // Recursively delete views - safe as all the views as all
in the same region
    -                            for (ViewInfo viewInfo : tableViewFinderResult.getViewInfoList())
{
    -                                byte[] viewTenantId = viewInfo.getTenantId();
    -                                byte[] viewSchemaName = viewInfo.getSchemaName();
    -                                byte[] viewName = viewInfo.getViewName();
    -                                byte[] viewKey = SchemaUtil.getTableKey(viewTenantId,
viewSchemaName, viewName);
    -                                Delete delete = new Delete(viewKey, clientTimeStamp);
    -                                rowsToDelete.add(delete);
    -                                acquireLock(region, viewKey, locks);
    -                                MetaDataMutationResult result = doDropTable(viewKey,
viewTenantId, viewSchemaName,
    -                                        viewName, null, PTableType.VIEW, rowsToDelete,
invalidateList, locks,
    -                                        tableNamesToDelete, sharedTablesToDelete, false,
clientVersion);
    -                                if (result.getMutationCode() != MutationCode.TABLE_ALREADY_EXISTS)
{ return result; }
    -                            }
    -                        }
    -                    } else {
    +                // check to see if the table has any child views
    +                try (Table hTable =
    +                        env.getTable(SchemaUtil.getPhysicalTableName(
    +                            PhoenixDatabaseMetaData.SYSTEM_CHILD_LINK_NAME_BYTES,
    +                            env.getConfiguration()))) {
    +                    boolean hasChildViews =
    +                            ViewFinder.hasChildViews(hTable, tenantId, schemaName, tableName,
    +                                clientTimeStamp);
    +                    if (hasChildViews && !isCascade) {
    --- End diff --
    
    Isn't there a race condition with this check?


---

Mime
View raw message