From dev-return-52502-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Fri Jun 15 02:16:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 94751180600 for ; Fri, 15 Jun 2018 02:16:03 +0200 (CEST) Received: (qmail 98012 invoked by uid 500); 15 Jun 2018 00:16:02 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 97998 invoked by uid 99); 15 Jun 2018 00:16:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jun 2018 00:16:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E3CB6C06BD for ; Fri, 15 Jun 2018 00:16:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id YdFi2kSxwwVg for ; Fri, 15 Jun 2018 00:16:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E797C5F1F7 for ; Fri, 15 Jun 2018 00:16:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 73BBBE0101 for ; Fri, 15 Jun 2018 00:16:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0E7302183B for ; Fri, 15 Jun 2018 00:16:00 +0000 (UTC) Date: Fri, 15 Jun 2018 00:16:00 +0000 (UTC) From: "Sergey Soldatov (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-4781) Phoenix client project's jar naming convention causes maven-deploy-plugin to fail MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-4781?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 513165#comment-16513165 ]=20 Sergey Soldatov commented on PHOENIX-4781: ------------------------------------------ we should change phoenix_utils.py as well because it looks for phoenix-*-cl= ient.jar to run sqlline. Not very familiar with maven-deploy-plugin, but is= there a chance to force it to use our names using deploy:deploy-file goal? > Phoenix client project's jar naming convention causes maven-deploy-plugin= to fail > -------------------------------------------------------------------------= -------- > > Key: PHOENIX-4781 > URL: https://issues.apache.org/jira/browse/PHOENIX-4781 > Project: Phoenix > Issue Type: Improvement > Reporter: Karan Mehta > Priority: Major > Attachments: PHOENIX-4781.001.patch > > > `maven-deploy-plugin` is used for deploying built artifacts to repository= provided by `distributionManagement` tag.=C2=A0The name of files that need= to be uploaded are either derived from pom file of the project or it gener= ates an temporary one on its own. > For `phoenix-client` project, we essentially create a shaded uber jar tha= t contains all dependencies and provide the project pom file for the plugin= to work. `maven-jar-plugin` is disabled for the project, hence the shade p= lugin essentially packages the jar. The final name of the shaded jar is def= ined as `phoenix-${project.version}-client`, which is different from how th= e standard maven convention based on pom file (artifact and group id) is `p= hoenix-client-${project.version}` > This causes `maven-deploy-plugin` to fail since it is unable to find any = artifacts to be published. > `maven-install-plugin` works correctly and hence it installs correct jar = in local repo. > The same is effective for `phoenix-pig` project as well. However we requi= re the require jar for that project in the repo. I am not even sure why we = create shaded jar for that project. > I will put up a 3 liner patch for the same. > Any thoughts? [~sergey.soldatov] [~elserj] > Files before change (first col is size): > {code:java} > 103487701 Jun 13 22:47 phoenix-4.14.0-HBase-1.3-sfdc-1.0.14-SNAPSHOT-clie= nt.jar{code} > Files=C2=A0after change (first col is size): > {code:java} > 3640 Jun 13 21:23 original-phoenix-client-4.14.0-HBase-1.3-sfdc-1.0.14-SN= APSHOT.jar > 103487702 Jun 13 21:24 phoenix-client-4.14.0-HBase-1.3-sfdc-1.0.14-SNAPSH= OT.jar{code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)