phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geoffrey Jacoby (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4786) Reduce log level to debug when logging new aggregate row key found and added results for scan ordered queries
Date Fri, 15 Jun 2018 22:34:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16514457#comment-16514457
] 

Geoffrey Jacoby commented on PHOENIX-4786:
------------------------------------------

+1, thanks [~rajeshbabu]

> Reduce log level to debug when logging new aggregate row key found and added results
for scan ordered queries
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-4786
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4786
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Rajeshbabu Chintaguntla
>            Assignee: Rajeshbabu Chintaguntla
>            Priority: Major
>             Fix For: 5.0.0, 4.15.0
>
>         Attachments: PHOENIX-4786.patch, PHOENIX-4786_v2.patch
>
>
> Currently we are logging key value when the new aggregate row found for scan ordered
queries which is info log. This is going to add lot of overhead to the queries because sometimes
we may write almost all the rows into log.
> {noformat}
>                     results.add(keyValue);
>                     if (logger.isInfoEnabled()) {
>                         logger.info(LogUtil.addCustomAnnotations("Adding new aggregate
row: "
>                                 + keyValue
>                                 + ",for current key "
>                                 + Bytes.toStringBinary(currentKey.get(), currentKey.getOffset(),
>                                     currentKey.getLength()) + ", aggregated values: "
>                                 + Arrays.asList(rowAggregators), ScanUtil.getCustomAnnotations(scan)));
>                     }
> {noformat}
> {noformat}
> [root@ctr-e138-1518143905142-358323-01-000010 hbase]# grep "Adding new aggregate row:
" hbase-hbase-regionserver-ctr-e138-1518143905142-358323-01-000010.log.* | wc -l
> 19082854
> {noformat}
> It's changed recently as part of PHOENIX-4742 so better to make it debug only.
> {noformat}
> -                    if (logger.isDebugEnabled()) {
> -                        logger.debug(LogUtil.addCustomAnnotations("Adding new aggregate
row: "
> +                    if (logger.isInfoEnabled()) {
> +                        logger.info(LogUtil.addCustomAnnotations("Adding new aggregate
row: "
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message