phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3534) Support multi region SYSTEM.CATALOG table
Date Fri, 01 Jun 2018 07:40:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497689#comment-16497689
] 

ASF GitHub Bot commented on PHOENIX-3534:
-----------------------------------------

Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/303#discussion_r192318659
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/PColumnImpl.java ---
    @@ -156,14 +209,14 @@ public String toString() {
             return (familyName == null ? "" : familyName.toString() + QueryConstants.NAME_SEPARATOR)
+ name.toString();
         }
         
    -    @Override
    -    public int hashCode() {
    -        final int prime = 31;
    -        int result = 1;
    -        result = prime * result + ((familyName == null) ? 0 : familyName.hashCode());
    -        result = prime * result + ((name == null) ? 0 : name.hashCode());
    -        return result;
    -    }
    +	@Override
    +	public int hashCode() {
    +	    final int prime = 31;
    +	    int result = 1;
    +	    result = prime * result + ((familyName == null) ? 0 : familyName.hashCode());
    +	    result = prime * result + ((name == null) ? 0 : name.hashCode());
    +	    return result;
    +	}
    --- End diff --
    
    Fixed


> Support multi region SYSTEM.CATALOG table
> -----------------------------------------
>
>                 Key: PHOENIX-3534
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3534
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Thomas D'Silva
>            Priority: Major
>         Attachments: PHOENIX-3534-wip.patch
>
>
> Currently Phoenix requires that the SYSTEM.CATALOG table is single region based on the
server-side row locks being held for operations that impact a table and all of it's views.
For example, adding/removing a column from a base table pushes this change to all views.
> As an alternative to making the SYSTEM.CATALOG transactional (PHOENIX-2431), when a new
table is created we can do a lazy cleanup  of any rows that may be left over from a failed
DDL call (kudos to [~lhofhansl] for coming up with this idea). To implement this efficiently,
we'd need to also do PHOENIX-2051 so that we can efficiently find derived views.
> The implementation would rely on an optimistic concurrency model based on checking our
sequence numbers for each table/view before/after updating. Each table/view row would be individually
locked for their change (metadata for a view or table cannot span regions due to our split
policy), with the sequence number being incremented under lock and then returned to the client.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message