From dev-return-51351-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Tue May 1 07:52:11 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7B44D180645 for ; Tue, 1 May 2018 07:52:10 +0200 (CEST) Received: (qmail 55359 invoked by uid 500); 1 May 2018 05:52:03 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 55346 invoked by uid 99); 1 May 2018 05:52:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 May 2018 05:52:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 921D5180709 for ; Tue, 1 May 2018 05:52:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id cQJ5GmUEKpR7 for ; Tue, 1 May 2018 05:52:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 4B0CC5F23B for ; Tue, 1 May 2018 05:52:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CE940E0175 for ; Tue, 1 May 2018 05:52:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 75B4121298 for ; Tue, 1 May 2018 05:52:00 +0000 (UTC) Date: Tue, 1 May 2018 05:52:00 +0000 (UTC) From: "James Taylor (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-4721) Issuing ALTER TABLE to add a PK Column to a table with secondary indexes fails MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-4721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16459467#comment-16459467 ] James Taylor commented on PHOENIX-4721: --------------------------------------- Please review, [~tdsilva]. This issue is due to two indexes being added - we should only increment the pk slot position after processing all indexes. > Issuing ALTER TABLE to add a PK Column to a table with secondary indexes fails > ------------------------------------------------------------------------------ > > Key: PHOENIX-4721 > URL: https://issues.apache.org/jira/browse/PHOENIX-4721 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.13.0 > Reporter: Jan Fernando > Priority: Major > Fix For: 4.14.0, 5.0.0 > > Attachments: AlterTableExtendPk.java, PHOENIX-4721_v1.patch > > > The expected behavior when adding a PK column to table is that the column will successfully be added, even if the table has secondary indexes. > For example: > {code:java} > ALTER TABLE TEST.ACTIVITY ADD SOURCE VARCHAR(25) NULL PRIMARY KEY > {code} > should execute successfully even if the table has secondary indexes defined. > However issuing the above ALTER statement on a table with secondary indexes throws the following Exception: > {code:java} > java.util.NoSuchElementException > at java.util.ArrayList$Itr.next(ArrayList.java:854) > at org.apache.phoenix.schema.RowKeyValueAccessor.(RowKeyValueAccessor.java:78) > at org.apache.phoenix.schema.MetaDataClient.addColumn(MetaDataClient.java:3452) > at org.apache.phoenix.schema.MetaDataClient.addColumn(MetaDataClient.java:3120) > at org.apache.phoenix.jdbc.PhoenixStatement$ExecutableAddColumnStatement$1.execute(PhoenixStatement.java:1328) > at org.apache.phoenix.jdbc.PhoenixStatement$3.call(PhoenixStatement.java:393) > at org.apache.phoenix.jdbc.PhoenixStatement$3.call(PhoenixStatement.java:1) > at org.apache.phoenix.call.CallRunner.run(CallRunner.java:53) > at org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:375) > at org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:363) > at org.apache.phoenix.jdbc.PhoenixStatement.execute(PhoenixStatement.java:269) > at org.apache.phoenix.jdbc.PhoenixPreparedStatement.execute(PhoenixPreparedStatement.java:172) > at org.apache.phoenix.jdbc.PhoenixPreparedStatement.execute(PhoenixPreparedStatement.java:177) > {code} > See attached file for a detailed repro. -- This message was sent by Atlassian JIRA (v7.6.3#76005)