From dev-return-51403-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Wed May 2 01:54:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D656A180677 for ; Wed, 2 May 2018 01:54:05 +0200 (CEST) Received: (qmail 64193 invoked by uid 500); 1 May 2018 23:54:04 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 64151 invoked by uid 99); 1 May 2018 23:54:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 May 2018 23:54:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 7DA73C5F4A for ; Tue, 1 May 2018 23:54:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id SDysLae1zCjc for ; Tue, 1 May 2018 23:54:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 436925F1F0 for ; Tue, 1 May 2018 23:54:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6C5E7E12B0 for ; Tue, 1 May 2018 23:54:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 81006212A4 for ; Tue, 1 May 2018 23:54:00 +0000 (UTC) Date: Tue, 1 May 2018 23:54:00 +0000 (UTC) From: "Hudson (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-4718) Decrease overhead of tracking aggregate heap size MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16460318#comment-16460318 ] Hudson commented on PHOENIX-4718: --------------------------------- FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #1849 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/1849/]) PHOENIX-4718 Decrease overhead of tracking aggregate heap size (jtaylor: rev 4096fc4893adeca871e97d5d5d60d2f332b572c4) * (edit) phoenix-core/src/main/java/org/apache/phoenix/query/QueryServices.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/expression/aggregator/DistinctValueWithCountServerAggregator.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/expression/aggregator/ServerAggregators.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/SpillableGroupByIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java * (add) phoenix-core/src/main/java/org/apache/phoenix/expression/aggregator/SizeTrackingServerAggregators.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/expression/aggregator/Aggregator.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java * (edit) phoenix-core/src/test/java/org/apache/phoenix/compile/QueryCompilerTest.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/expression/aggregator/BaseAggregator.java * (edit) phoenix-core/src/test/java/org/apache/phoenix/query/QueryServicesTestImpl.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/execute/ClientAggregatePlan.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/expression/aggregator/Aggregators.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/expression/aggregator/ClientAggregators.java * (add) phoenix-core/src/main/java/org/apache/phoenix/expression/aggregator/NonSizeTrackingServerAggregators.java > Decrease overhead of tracking aggregate heap size > ------------------------------------------------- > > Key: PHOENIX-4718 > URL: https://issues.apache.org/jira/browse/PHOENIX-4718 > Project: Phoenix > Issue Type: Bug > Reporter: James Taylor > Assignee: James Taylor > Priority: Major > Fix For: 4.14.0, 5.0.0 > > Attachments: PHOENIX-4718-4.x-HBase-0.98.patch, PHOENIX-4718.patch, PHOENIX-4718_v2.patch, PHOENIX-4718_v3.patch > > > Since PHOENIX-4148, we track the heap size while aggregation is occurring. This decreased performance of aggregation by ~20%. We really only need to track this for the DistinctValueWithCountServerAggregator (used by DISTINCT COUNT, DISTINCT, PERCENTILE functions, and STDDEV functions). By conditionally tracking, we should be able to bring perf back to what it was before. -- This message was sent by Atlassian JIRA (v7.6.3#76005)