From dev-return-51389-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Tue May 1 22:56:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6CE76180645 for ; Tue, 1 May 2018 22:56:05 +0200 (CEST) Received: (qmail 95342 invoked by uid 500); 1 May 2018 20:56:02 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 95331 invoked by uid 99); 1 May 2018 20:56:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 May 2018 20:56:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 695061A035C for ; Tue, 1 May 2018 20:56:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id xWEFt3M-U7r2 for ; Tue, 1 May 2018 20:56:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id F24975F3F0 for ; Tue, 1 May 2018 20:56:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 69F03E0CCB for ; Tue, 1 May 2018 20:56:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 231352129B for ; Tue, 1 May 2018 20:56:00 +0000 (UTC) Date: Tue, 1 May 2018 20:56:00 +0000 (UTC) From: "James Taylor (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-4712) When creating an index on a table, meta data cache of views related to the table isn't updated MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-4712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16460144#comment-16460144 ] James Taylor commented on PHOENIX-4712: --------------------------------------- Thanks for the patch, [~tdsilva]. Seems like there are two approaches: * Add the indexes from the parent every time we resolve the view. Do you think this will be a perf issue? * Invalidate the table from the client that does the CREATE TABLE call. There'll be an extra RPC for this connection (but other connections would already do this). Which approach do you think is the best? > When creating an index on a table, meta data cache of views related to the table isn't updated > ---------------------------------------------------------------------------------------------- > > Key: PHOENIX-4712 > URL: https://issues.apache.org/jira/browse/PHOENIX-4712 > Project: Phoenix > Issue Type: Bug > Reporter: Toshihiro Suzuki > Assignee: Toshihiro Suzuki > Priority: Major > Attachments: PHOENIX-4712-v2.patch, PHOENIX-4712.patch, PHOENIX-4712.patch, PHOENIX-4712_v3.patch > > > Steps to reproduce are as follows: > 1. Create a table > {code} > create table tbl (col1 varchar primary key, col2 varchar); > {code} > 2. Create a view on the table > {code} > create view vw (col3 varchar) as select * from tbl; > {code} > 3. Create a index on the table > {code} > create index idx ON tbl (col2); > {code} > After those, when issuing a explain query like the following, it seems like the query doesn't use the index, although the index should be used: > {code} > 0: jdbc:phoenix:> explain select /*+ INDEX(vw idx) */ * from vw where col2 = 'aaa'; > +---------------------------------------------------------------+ > | PLAN | > +---------------------------------------------------------------+ > | CLIENT 1-CHUNK PARALLEL 1-WAY ROUND ROBIN FULL SCAN OVER TBL | > | SERVER FILTER BY COL2 = 'aaa' | > +---------------------------------------------------------------+ > {code} > However, after restarting sqlline, the explain output is changed, and the index is used. > {code} > 0: jdbc:phoenix:> explain select /*+ INDEX(vw idx) */ * from vw where col2 = 'aaa'; > +--------------------------------------------------------------------------------+ > | PLAN | > +--------------------------------------------------------------------------------+ > | CLIENT 1-CHUNK PARALLEL 1-WAY ROUND ROBIN FULL SCAN OVER TBL | > | SKIP-SCAN-JOIN TABLE 0 | > | CLIENT 1-CHUNK PARALLEL 1-WAY ROUND ROBIN RANGE SCAN OVER IDX ['aaa'] | > | SERVER FILTER BY FIRST KEY ONLY | > | DYNAMIC SERVER FILTER BY "VW.COL1" IN ($3.$5) | > +--------------------------------------------------------------------------------+ > {code} > I think when creating an index on a table, meta data cache of views related to the table isn't updated, so the index isn't used for that query. However after restarting sqlline, the meta data cache is refreshed, so the index is used. > When creating an index on a table, we should update meta data cache of views related to the table. -- This message was sent by Atlassian JIRA (v7.6.3#76005)