From dev-return-52152-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Thu May 31 01:04:36 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C035C18063B for ; Thu, 31 May 2018 01:04:35 +0200 (CEST) Received: (qmail 91832 invoked by uid 500); 30 May 2018 23:04:34 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 91815 invoked by uid 99); 30 May 2018 23:04:34 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 May 2018 23:04:34 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 0CFA3E0AD2; Wed, 30 May 2018 23:04:34 +0000 (UTC) From: churrodog To: dev@phoenix.apache.org Reply-To: dev@phoenix.apache.org References: In-Reply-To: Subject: [GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ... Content-Type: text/plain Message-Id: <20180530230434.0CFA3E0AD2@git1-us-west.apache.org> Date: Wed, 30 May 2018 23:04:34 +0000 (UTC) Github user churrodog commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r191948951 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/WhereConstantParser.java --- @@ -0,0 +1,113 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * http://www.apache.org/licenses/LICENSE-2.0 + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.phoenix.coprocessor; + +import static org.apache.phoenix.util.PhoenixRuntime.CONNECTIONLESS; +import static org.apache.phoenix.util.PhoenixRuntime.JDBC_PROTOCOL; +import static org.apache.phoenix.util.PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR; + +import java.sql.DriverManager; +import java.sql.SQLException; +import java.util.BitSet; +import java.util.List; + +import org.apache.phoenix.compile.ColumnResolver; +import org.apache.phoenix.compile.CreateTableCompiler; +import org.apache.phoenix.compile.ExpressionCompiler; +import org.apache.phoenix.compile.FromCompiler; +import org.apache.phoenix.compile.StatementContext; +import org.apache.phoenix.compile.WhereCompiler; +import org.apache.phoenix.expression.Expression; +import org.apache.phoenix.jdbc.PhoenixConnection; +import org.apache.phoenix.jdbc.PhoenixStatement; +import org.apache.phoenix.parse.ParseNode; +import org.apache.phoenix.parse.SQLParser; +import org.apache.phoenix.parse.SelectStatement; +import org.apache.phoenix.schema.ColumnNotFoundException; +import org.apache.phoenix.schema.PColumn; +import org.apache.phoenix.schema.PColumnImpl; +import org.apache.phoenix.schema.PTable; +import org.apache.phoenix.schema.PTableImpl; +import org.apache.phoenix.schema.TableRef; +import org.apache.phoenix.util.MetaDataUtil; + +import com.google.common.collect.Lists; + + +public class WhereConstantParser { + + static PTable addViewInfoToPColumnsIfNeeded(PTable view) throws SQLException { + boolean[] viewColumnConstantsMatched = new boolean[view.getColumns().size()]; + byte[][] viewColumnConstantsToBe = new byte[view.getColumns().size()][]; + if (view.getViewStatement() == null) { + return view; + } + SelectStatement select = new SQLParser(view.getViewStatement()).parseQuery(); + ParseNode whereNode = select.getWhere(); + ColumnResolver resolver = FromCompiler.getResolver(new TableRef(view)); + StatementContext context = new StatementContext(new PhoenixStatement(getConnectionlessConnection()), resolver); + Expression expression = null; + try { + expression = WhereCompiler.compile(context, whereNode); + } + catch (ColumnNotFoundException e) { + // if we could not find a column used in the view statement (which means its was dropped) + // this view is not valid any more + return null; + } + CreateTableCompiler.ViewWhereExpressionVisitor visitor = + new CreateTableCompiler.ViewWhereExpressionVisitor(view, viewColumnConstantsToBe); + expression.accept(visitor); + + BitSet isViewColumnReferencedToBe = new BitSet(view.getColumns().size()); + // Used to track column references in a view + ExpressionCompiler expressionCompiler = new CreateTableCompiler.ColumnTrackingExpressionCompiler(context, isViewColumnReferencedToBe); + whereNode.accept(expressionCompiler); + + List result = Lists.newArrayList(); + for (PColumn column : PTableImpl.getColumnsToClone(view)) { + boolean isViewReferenced = isViewColumnReferencedToBe.get(column.getPosition()); + if ( (visitor.isUpdatable() || view.getPKColumns().get(MetaDataUtil.getAutoPartitionColIndex(view)).equals(column)) + && viewColumnConstantsToBe[column.getPosition()] != null) { + result.add(new PColumnImpl(column, viewColumnConstantsToBe[column.getPosition()], isViewReferenced)); + viewColumnConstantsMatched[column.getPosition()]=true; + } + // If view is not updatable, viewColumnConstants should be empty. We will still + // inherit our parent viewConstants, but we have no additional ones. + else if(isViewReferenced ){ + result.add(new PColumnImpl(column, column.getViewConstant(), isViewReferenced)); + } + else { + result.add(column); + } + } + // ensure that node of the columns in the view where statement were + // dropped in any of this views ancestors +// for (int i = 0; i < viewColumnConstantsMatched.length; ++i) { --- End diff -- should this be removed, or is this still valid? ---