From dev-return-52115-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Wed May 30 23:54:44 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 240B618063B for ; Wed, 30 May 2018 23:54:43 +0200 (CEST) Received: (qmail 57429 invoked by uid 500); 30 May 2018 21:54:43 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 57418 invoked by uid 99); 30 May 2018 21:54:42 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 May 2018 21:54:42 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 71935E10F1; Wed, 30 May 2018 21:54:42 +0000 (UTC) From: JamesRTaylor To: dev@phoenix.apache.org Reply-To: dev@phoenix.apache.org References: In-Reply-To: Subject: [GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ... Content-Type: text/plain Message-Id: <20180530215442.71935E10F1@git1-us-west.apache.org> Date: Wed, 30 May 2018 21:54:42 +0000 (UTC) Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r191935338 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/PColumnImpl.java --- @@ -156,14 +209,14 @@ public String toString() { return (familyName == null ? "" : familyName.toString() + QueryConstants.NAME_SEPARATOR) + name.toString(); } - @Override - public int hashCode() { - final int prime = 31; - int result = 1; - result = prime * result + ((familyName == null) ? 0 : familyName.hashCode()); - result = prime * result + ((name == null) ? 0 : name.hashCode()); - return result; - } + @Override + public int hashCode() { + final int prime = 31; + int result = 1; + result = prime * result + ((familyName == null) ? 0 : familyName.hashCode()); + result = prime * result + ((name == null) ? 0 : name.hashCode()); + return result; + } --- End diff -- Minor nit - various formatting issues. Not sure if there are tabs now or if the indenting was wrong before. ---