phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4742) DistinctPrefixFilter potentially seeks to lesser key when descending or null value
Date Wed, 23 May 2018 19:37:01 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487918#comment-16487918
] 

Hudson commented on PHOENIX-4742:
---------------------------------

FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #1885 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/1885/])
PHOENIX-4742 DistinctPrefixFilter potentially seeks to lesser key when (jtaylor: rev 48b6f99acdeb91e3167e7beeed49747f7b7dcc6c)
* (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/filter/DistinctPrefixFilter.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/filter/SkipScanFilter.java
* (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/OrderByIT.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/schema/RowKeySchema.java


> DistinctPrefixFilter potentially seeks to lesser key when descending or null value
> ----------------------------------------------------------------------------------
>
>                 Key: PHOENIX-4742
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4742
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>            Priority: Major
>             Fix For: 4.14.0, 5.0.0
>
>         Attachments: PHOENIX-4742_v1.patch
>
>
> DistinctPrefixFilter seeks to a smaller key than the current key (which causes an infinite
loop in HBase 1.4 and seeks to every row in other HBase versions). This happens when:
>  # Last column of distinct is descending. We currently always add a 0x01 byte, but since
the separator byte if 0xFF when descending, the seek key is too small.
>  # Last column value is null. In this case, instead of adding a 0x01 byte, we need
to increment in-place the null value of the last distinct column. 
> This was discovered due to OrderByIT.testOrderByReverseOptimizationWithNUllsLastBug3491
hanging in master.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message