phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4741) Shade disruptor dependency
Date Mon, 21 May 2018 21:24:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483076#comment-16483076
] 

Josh Elser commented on PHOENIX-4741:
-------------------------------------

{quote}I would suggest we should revisit and start publishing our shaded artifacts as well
{quote}
I'd support that, but would suggest you re-open PHOENIX-1567 and do that work there (I'm sure
you would have on your own).
{quote}And, there is a bug where during "mvn install" phoenix-client.jar and then phoenix-server
jar are copied in phoenix-core path resulting phoenix-server.jar to act as our phoenix-core.jar,
attached patch should fix it.
{quote}
Seems separate from the original intent of this change still. Should have a new Jira issue
for this bug?

I feel like a better fix might be to just remove that {{maven-install-plugin}} configuration.
If we attach the shaded artifact to the build (as you would change in PHOENIX-1567), I think
explicitly stating this plugin would be unnecessary... (I think ;))

> Shade disruptor dependency 
> ---------------------------
>
>                 Key: PHOENIX-4741
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4741
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.14.0, 5.0.0
>            Reporter: Jungtaek Lim
>            Assignee: Ankit Singhal
>            Priority: Major
>             Fix For: 4.14.0, 5.0.0
>
>         Attachments: PHOENIX-4741.patch
>
>
> We should shade disruptor dependency to avoid conflict with the versions used by the
other framework like storm , hive etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message