phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4728) ARRAY_APPEND and ARRAY_REMOVE should work with null column value
Date Fri, 25 May 2018 12:16:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490632#comment-16490632
] 

ASF GitHub Bot commented on PHOENIX-4728:
-----------------------------------------

Github user xjodoin commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/301#discussion_r190875305
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java ---
    @@ -549,7 +549,7 @@ public MutationPlan compile(UpsertStatement upsert) throws SQLException
{
                 select = SelectStatement.create(select, hint);
                 // Pass scan through if same table in upsert and select so that projection
is computed correctly
                 // Use optimizer to choose the best plan
    -            QueryCompiler compiler = new QueryCompiler(statement, select, selectResolver,
targetColumns, parallelIteratorFactoryToBe, new SequenceManager(statement), false, false,
null);
    +            QueryCompiler compiler = new QueryCompiler(statement, select, selectResolver,
targetColumns, parallelIteratorFactoryToBe, new SequenceManager(statement), true, false, null);
    --- End diff --
    
    All the tests passed


> ARRAY_APPEND and ARRAY_REMOVE should work with null column value
> ----------------------------------------------------------------
>
>                 Key: PHOENIX-4728
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4728
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.14.0
>            Reporter: Xavier Jodoin
>            Priority: Major
>
> ARRAY_APPEND and ARRAY_REMOVE should create the array value when it's null
> Test case:
> create table test_array (
> ID VARCHAR NOT NULL,
> MYARRAY VARCHAR ARRAY
> CONSTRAINT testpk PRIMARY KEY (ID)
> );
> upsert into test_array (id) values ('test');
> upsert into test_array select id,array_append(myarray,'testValue') from test_array;
> select ID,ARRAY_TO_STRING(MYARRAY, ',')  from test_array;
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message