phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4718) Decrease overhead of tracking aggregate heap size
Date Tue, 01 May 2018 23:54:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16460318#comment-16460318
] 

Hudson commented on PHOENIX-4718:
---------------------------------

FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #1849 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/1849/])
PHOENIX-4718 Decrease overhead of tracking aggregate heap size (jtaylor: rev 4096fc4893adeca871e97d5d5d60d2f332b572c4)
* (edit) phoenix-core/src/main/java/org/apache/phoenix/query/QueryServices.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/expression/aggregator/DistinctValueWithCountServerAggregator.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/expression/aggregator/ServerAggregators.java
* (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/SpillableGroupByIT.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
* (add) phoenix-core/src/main/java/org/apache/phoenix/expression/aggregator/SizeTrackingServerAggregators.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/expression/aggregator/Aggregator.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java
* (edit) phoenix-core/src/test/java/org/apache/phoenix/compile/QueryCompilerTest.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/expression/aggregator/BaseAggregator.java
* (edit) phoenix-core/src/test/java/org/apache/phoenix/query/QueryServicesTestImpl.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/execute/ClientAggregatePlan.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/expression/aggregator/Aggregators.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/expression/aggregator/ClientAggregators.java
* (add) phoenix-core/src/main/java/org/apache/phoenix/expression/aggregator/NonSizeTrackingServerAggregators.java


> Decrease overhead of tracking aggregate heap size
> -------------------------------------------------
>
>                 Key: PHOENIX-4718
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4718
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>            Priority: Major
>             Fix For: 4.14.0, 5.0.0
>
>         Attachments: PHOENIX-4718-4.x-HBase-0.98.patch, PHOENIX-4718.patch, PHOENIX-4718_v2.patch,
PHOENIX-4718_v3.patch
>
>
> Since PHOENIX-4148, we track the heap size while aggregation is occurring. This decreased
performance of aggregation by ~20%. We really only need to track this for the DistinctValueWithCountServerAggregator
(used by DISTINCT COUNT, DISTINCT, PERCENTILE functions, and STDDEV functions). By conditionally
tracking, we should be able to bring perf back to what it was before.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message