phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4718) Decrease overhead of tracking aggregate heap size
Date Tue, 01 May 2018 05:04:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16459449#comment-16459449
] 

James Taylor commented on PHOENIX-4718:
---------------------------------------

Thanks, [~tdsilva]. I attached a cleaned up v3 patch that:
 * Makes the size increase configurable
 * Uses separate ServerAggregators classes for the tracking versus non tracking case

> Decrease overhead of tracking aggregate heap size
> -------------------------------------------------
>
>                 Key: PHOENIX-4718
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4718
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>            Priority: Major
>             Fix For: 4.14.0, 5.0.0
>
>         Attachments: PHOENIX-4718-4.x-HBase-0.98.patch, PHOENIX-4718.patch, PHOENIX-4718_v2.patch,
PHOENIX-4718_v3.patch
>
>
> Since PHOENIX-4148, we track the heap size while aggregation is occurring. This decreased
performance of aggregation by ~20%. We really only need to track this for the DistinctValueWithCountServerAggregator
(used by DISTINCT COUNT, DISTINCT, PERCENTILE functions, and STDDEV functions). By conditionally
tracking, we should be able to bring perf back to what it was before.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message