phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ankit Singhal (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-4701) Write client-side metrics asynchronously to SYSTEM.LOG
Date Fri, 11 May 2018 19:11:00 GMT


Ankit Singhal commented on PHOENIX-4701:

{quote}Do the test in QueryLoggerIT pass?
Yes, it was passing with wip and current patch both



If you're ok with it, I think we should get this into 4.14. We can mark it as beta while
we get feedback. It can be disabled completely, correct
Yes, I think we should have this in 4.14 to avoid upgrade for log table in later releases.
Beta should be fine as it can be disabled completely.


Did you see the LoggingPhoenixConnection and others like LoggingPhoenixResultSet and see
how they manage the lifecycle of metrics? 
Yes I checked that, Not sure why PhoenixRuntime.resetMetrics(rs) is required as every query
has it's own instance of ReadMetricQueue and OverAllQueryMetrics.

> Write client-side metrics asynchronously to SYSTEM.LOG
> ------------------------------------------------------
>                 Key: PHOENIX-4701
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>            Priority: Major
>             Fix For: 4.15.0
>         Attachments: PHOENIX-4701.patch, PHOENIX-4701_master.patch, PHOENIX-4701_wip1.patch,
PHOENIX-4701_wip2.patch, PHOENIX-4701_wip3.patch
> Rather than inventing a new, different set of client-side metrics to persist, we should
just persist our [client metrics|] in the SYSTEM.LOG.
The metrics captures all the same information as your QueryLogInfo (and much more), rolls
all the information up to a single set of metrics for each Phoenix statement (aggregating/merging
parallel scans, etc), and can emits a single log line (which could be written in a single
upsert statement). At SFDC, we emit this information into a file system log in a layer above
(and use Splunk to produce nifty dashboard for monitoring), but this could easily be emitted
directly in Phoenix and go through your asynchronous write path (and then use Phoenix queries
to produce the same kind of dashboards). The only piece would be to add the concept of a log
level to each metric to enable statically controlling which metrics are output.
> With this approach, the SYSTEM.LOG table could be declared immutable and use our dense
storage format with a single byte for column encoding and get a 3-5x perf gain. This would
also open the door for users to potentially add secondary indexes on the table. See schema
identified in the wip2 patch.

This message was sent by Atlassian JIRA

View raw message