phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (PHOENIX-3856) StatementContext class constructor not honouring supplied scan object
Date Thu, 03 May 2018 16:35:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462731#comment-16462731
] 

James Taylor edited comment on PHOENIX-3856 at 5/3/18 4:34 PM:
---------------------------------------------------------------

+1. Not critical, though, because the only caller is the one arg constructor that passes in
a new Scan anyway, but we should still fix for code cleanliness sake.


was (Author: jamestaylor):
+1

> StatementContext class  constructor not honouring supplied scan object
> ----------------------------------------------------------------------
>
>                 Key: PHOENIX-3856
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3856
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.10.0
>            Reporter: Maddineni Sukumar
>            Assignee: Maddineni Sukumar
>            Priority: Minor
>             Fix For: 4.14.0
>
>         Attachments: PHOENIX-3856.patch
>
>
> In below constructor  we are creating additional scan object instead of supplied scan
object. 
>  public StatementContext(PhoenixStatement statement, Scan scan) {
>         this(statement, FromCompiler.EMPTY_TABLE_RESOLVER, new Scan(), new SequenceManager(statement));
>     }



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message