phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3655) Metrics for PQS
Date Thu, 17 May 2018 18:25:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479510#comment-16479510
] 

Josh Elser commented on PHOENIX-3655:
-------------------------------------

{quote}Do you want to move towards {{MetricRegistry}} provided by HBase? 
{quote}
Yeah, definitely. Getting us on hbase-metrics _should_ be a gain for us (no more janky Hadoop
metrics2)

The rest of what you were saying is about on track: we use the hbase-metrics-api to construct
the things we're measuring, sending them to the MetricsRegistry. Then, HBase (or the reporter
we configure on the Registry) would take care of pushing those to Hadoop Metrics2 sink. There
may be something in place already with the underlying dropwizard metrics implementation to
push all of these to JMX (as an aside).

I fear you might be getting sucked into some old metrics cruft in HBase, [~karanmehta93].
BaseSourceImpl and other classes in hbase-hadoop2-compat are vestigial to prevent having to
rewrite all of hbase-server to use the new hbase-metrics-api. I would think that if you're
coming in here fresh, you could just use hbase-metrics-api only and ignore all of that other
stuff.

> Metrics for PQS
> ---------------
>
>                 Key: PHOENIX-3655
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3655
>             Project: Phoenix
>          Issue Type: New Feature
>    Affects Versions: 4.8.0
>         Environment: Linux 3.13.0-107-generic kernel, v4.9.0-HBase-0.98
>            Reporter: Rahul Shrivastava
>            Assignee: Karan Mehta
>            Priority: Major
>             Fix For: 4.15.0
>
>         Attachments: MetricsforPhoenixQueryServerPQS.pdf
>
>   Original Estimate: 240h
>  Remaining Estimate: 240h
>
> Phoenix Query Server runs a separate process compared to its thin client. Metrics collection
is currently done by PhoenixRuntime.java i.e. at Phoenix driver level. We need the following
> 1. For every jdbc statement/prepared statement/ run by PQS , we need capability to collect
metrics at PQS level and push the data to external sink i.e. file, JMX , other external custom
sources. 
> 2. Besides this global metrics could be periodically collected and pushed to the sink.

> 2. PQS can be configured to turn on metrics collection and type of collect ( runtime
or global) via hbase-site.xml
> 3. Sink could be configured via an interface in hbase-site.xml. 
> All metrics definition https://phoenix.apache.org/metrics.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message