phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-3534) Support multi region SYSTEM.CATALOG table
Date Wed, 30 May 2018 22:10:00 GMT


ASF GitHub Bot commented on PHOENIX-3534:

Github user twdsilva commented on a diff in the pull request:
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/
    @@ -586,48 +573,336 @@ public void getTable(RpcController controller, GetTableRequest
                         builder.setMutationTime(minNonZerodisableIndexTimestamp - 1);
    -            if (table.getTimeStamp() != tableTimeStamp) {
    +            // the PTable of views and indexes on views might get updated because a column
is added to one of
    +            // their parents (this won't change the timestamp)
    +            if (table.getType()!=PTableType.TABLE || table.getTimeStamp() != tableTimeStamp)
    -            return;
             } catch (Throwable t) {
                 logger.error("getTable failed", t);
                     ServerUtil.createIOException(SchemaUtil.getTableName(schemaName, tableName),
    +    /**
    +     * Used to add the columns present the ancestor hierarchy to the PTable of the given
view or
    +     * view index
    +     * @param table PTable of the view or view index
    +     * @param skipAddingIndexes if true the returned PTable won't include indexes
    +     * @param skipAddingParentColumns if true the returned PTable won't include columns
derived from ancestor tables
    +     */
    +    private Pair<PTable, MetaDataProtos.MutationCode> combineColumns(PTable table,
long timestamp,
    +            int clientVersion, boolean skipAddingIndexes, boolean skipAddingParentColumns)
throws SQLException, IOException {
    +        boolean hasIndexId = table.getViewIndexId() != null;
    +        if (table.getType() != PTableType.VIEW && !hasIndexId) {
    --- End diff --
    We only need to combine columns for a VIEW or an index on a VIEW. I will add a comment
for this.

> Support multi region SYSTEM.CATALOG table
> -----------------------------------------
>                 Key: PHOENIX-3534
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Thomas D'Silva
>            Priority: Major
>         Attachments: PHOENIX-3534-wip.patch
> Currently Phoenix requires that the SYSTEM.CATALOG table is single region based on the
server-side row locks being held for operations that impact a table and all of it's views.
For example, adding/removing a column from a base table pushes this change to all views.
> As an alternative to making the SYSTEM.CATALOG transactional (PHOENIX-2431), when a new
table is created we can do a lazy cleanup  of any rows that may be left over from a failed
DDL call (kudos to [~lhofhansl] for coming up with this idea). To implement this efficiently,
we'd need to also do PHOENIX-2051 so that we can efficiently find derived views.
> The implementation would rely on an optimistic concurrency model based on checking our
sequence numbers for each table/view before/after updating. Each table/view row would be individually
locked for their change (metadata for a view or table cannot span regions due to our split
policy), with the sequence number being incremented under lock and then returned to the client.

This message was sent by Atlassian JIRA

View raw message