phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...
Date Wed, 30 May 2018 22:06:55 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/303#discussion_r191938147
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
    @@ -586,48 +573,336 @@ public void getTable(RpcController controller, GetTableRequest
request,
                         builder.setMutationTime(minNonZerodisableIndexTimestamp - 1);
                     }
                 }
    -
    -            if (table.getTimeStamp() != tableTimeStamp) {
    +            // the PTable of views and indexes on views might get updated because a column
is added to one of
    +            // their parents (this won't change the timestamp)
    +            if (table.getType()!=PTableType.TABLE || table.getTimeStamp() != tableTimeStamp)
{
                     builder.setTable(PTableImpl.toProto(table));
                 }
                 done.run(builder.build());
    -            return;
             } catch (Throwable t) {
                 logger.error("getTable failed", t);
                 ProtobufUtil.setControllerException(controller,
                     ServerUtil.createIOException(SchemaUtil.getTableName(schemaName, tableName),
t));
             }
         }
     
    +    /**
    +     * Used to add the columns present the ancestor hierarchy to the PTable of the given
view or
    +     * view index
    +     * @param table PTable of the view or view index
    +     * @param skipAddingIndexes if true the returned PTable won't include indexes
    +     * @param skipAddingParentColumns if true the returned PTable won't include columns
derived from ancestor tables
    +     */
    +    private Pair<PTable, MetaDataProtos.MutationCode> combineColumns(PTable table,
long timestamp,
    +            int clientVersion, boolean skipAddingIndexes, boolean skipAddingParentColumns)
throws SQLException, IOException {
    +        boolean hasIndexId = table.getViewIndexId() != null;
    +        if (table.getType() != PTableType.VIEW && !hasIndexId) {
    --- End diff --
    
    Just curious - why does the viewIndexId determine whether or not the table already exists?


---

Mime
View raw message