phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...
Date Wed, 30 May 2018 21:54:42 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/303#discussion_r191935338
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/PColumnImpl.java ---
    @@ -156,14 +209,14 @@ public String toString() {
             return (familyName == null ? "" : familyName.toString() + QueryConstants.NAME_SEPARATOR)
+ name.toString();
         }
         
    -    @Override
    -    public int hashCode() {
    -        final int prime = 31;
    -        int result = 1;
    -        result = prime * result + ((familyName == null) ? 0 : familyName.hashCode());
    -        result = prime * result + ((name == null) ? 0 : name.hashCode());
    -        return result;
    -    }
    +	@Override
    +	public int hashCode() {
    +	    final int prime = 31;
    +	    int result = 1;
    +	    result = prime * result + ((familyName == null) ? 0 : familyName.hashCode());
    +	    result = prime * result + ((name == null) ? 0 : name.hashCode());
    +	    return result;
    +	}
    --- End diff --
    
    Minor nit - various formatting issues. Not sure if there are tabs now or if the indenting
was wrong before.


---

Mime
View raw message