phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...
Date Wed, 30 May 2018 21:15:25 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/303#discussion_r191925360
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ExplainPlanWithStatsEnabledIT.java
---
    @@ -1202,33 +1202,44 @@ private void testUseStatsForParallelizationOnSaltedTable(boolean
useStatsFlag, b
             assertEquals("B", rs.getString(1));
         }
     
    -	@Test
    -	public void testUseStatsForParallelizationProperyOnViewIndex() throws SQLException {
    -		String tableName = generateUniqueName();
    -		String viewName = generateUniqueName();
    -		String tenantViewName = generateUniqueName();
    -		String viewIndexName = generateUniqueName();
    -		boolean useStats = !DEFAULT_USE_STATS_FOR_PARALLELIZATION;
    -		try (Connection conn = DriverManager.getConnection(getUrl())) {
    -			conn.createStatement()
    -					.execute("create table " + tableName
    -							+ "(tenantId CHAR(15) NOT NULL, pk1 integer NOT NULL, v varchar CONSTRAINT PK
PRIMARY KEY "
    -							+ "(tenantId, pk1)) MULTI_TENANT=true");
    -			try (Connection tenantConn = getTenantConnection("tenant1")) {
    -				conn.createStatement().execute("CREATE VIEW " + viewName + " AS SELECT * FROM " +
tableName);
    -				conn.createStatement().execute("CREATE INDEX " + viewIndexName + " on " + viewName
+ " (v) ");
    -				tenantConn.createStatement().execute("CREATE VIEW " + tenantViewName + " AS SELECT
* FROM " + viewName);
    -				conn.createStatement()
    -						.execute("ALTER TABLE " + tableName + " set USE_STATS_FOR_PARALLELIZATION=" + useStats);
    -				// fetch the latest view ptable 
    -				PhoenixRuntime.getTableNoCache(tenantConn, viewName);
    -				PhoenixConnection phxConn = conn.unwrap(PhoenixConnection.class);
    -				PTable viewIndex = phxConn.getTable(new PTableKey(phxConn.getTenantId(), viewIndexName));
    -				assertEquals("USE_STATS_FOR_PARALLELIZATION property set incorrectly", useStats,
    -						PhoenixConfigurationUtil
    -								.getStatsForParallelizationProp(tenantConn.unwrap(PhoenixConnection.class), viewIndex));
    -			}
    -		}
    -	}
    +    @Test
    +    public void testUseStatsForParallelizationProperyOnViewIndex() throws SQLException
{
    +        String tableName = generateUniqueName();
    +        String viewName = generateUniqueName();
    +        String tenantViewName = generateUniqueName();
    +        String viewIndexName = generateUniqueName();
    +        boolean useStats = !DEFAULT_USE_STATS_FOR_PARALLELIZATION;
    +        try (Connection conn = DriverManager.getConnection(getUrl())) {
    +            conn.createStatement()
    +                    .execute("create table " + tableName
    +                            + "(tenantId CHAR(15) NOT NULL, pk1 integer NOT NULL, v varchar
CONSTRAINT PK PRIMARY KEY "
    +                            + "(tenantId, pk1)) MULTI_TENANT=true");
    +            try (Connection tenantConn = getTenantConnection("tenant1")) {
    +                conn.createStatement().execute("CREATE VIEW " + viewName + " AS SELECT
* FROM " + tableName);
    +                conn.createStatement().execute("CREATE INDEX " + viewIndexName + " on
" + viewName + " (v) ");
    +                tenantConn.createStatement().execute("CREATE VIEW " + tenantViewName
+ " AS SELECT * FROM " + viewName);
    +                conn.createStatement()
    +                        .execute("ALTER TABLE " + tableName + " set USE_STATS_FOR_PARALLELIZATION="
+ useStats);
    +                // changing a property on a base table does not change the property on
a view
    --- End diff --
    
    Shouldn't setting a property on the base table impact the view as well? In this case,
USE_STATS_FOR_PARALLELIZATION only makes sense to set on a physical table. I think we only
look it up from a physical table as well, so this is somewhat moot, but in general, I'd think
that setting a property on a base table should be seen by it's views if the property has not
been set there.


---

Mime
View raw message