phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xjodoin <...@git.apache.org>
Subject [GitHub] phoenix pull request #301: PHOENIX-4728 The upsert select must project tuple...
Date Fri, 25 May 2018 12:15:32 GMT
Github user xjodoin commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/301#discussion_r190875305
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java ---
    @@ -549,7 +549,7 @@ public MutationPlan compile(UpsertStatement upsert) throws SQLException
{
                 select = SelectStatement.create(select, hint);
                 // Pass scan through if same table in upsert and select so that projection
is computed correctly
                 // Use optimizer to choose the best plan
    -            QueryCompiler compiler = new QueryCompiler(statement, select, selectResolver,
targetColumns, parallelIteratorFactoryToBe, new SequenceManager(statement), false, false,
null);
    +            QueryCompiler compiler = new QueryCompiler(statement, select, selectResolver,
targetColumns, parallelIteratorFactoryToBe, new SequenceManager(statement), true, false, null);
    --- End diff --
    
    All the tests passed


---

Mime
View raw message