phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ortutay <...@git.apache.org>
Subject [GitHub] phoenix pull request #298: PHOENIX-4666 Persistent subquery cache for hash j...
Date Tue, 15 May 2018 23:04:06 GMT
Github user ortutay commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/298#discussion_r188461941
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/cache/ServerCacheClient.java ---
    @@ -216,22 +234,146 @@ public void close() throws SQLException {
                     }
                 }
             }
    -        
    +    }
    +    
    +    public ServerCache checkServerCache(final byte[] cacheId, ScanRanges keyRanges, final
TableRef cacheUsingTableRef,
    --- End diff --
    
    Yea makes sense. For this, I'm thinking of modifying the retry logic in BaseResultIterators
to disable persistent caching on retries. I'm thinking I can add a get/set'er pair to the
"context" that can be used for this


---

Mime
View raw message