phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request #298: PHOENIX-4666 Persistent subquery cache for hash j...
Date Thu, 10 May 2018 17:04:51 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/298#discussion_r187393698
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/cache/ServerCacheClient.java ---
    @@ -216,22 +234,146 @@ public void close() throws SQLException {
                     }
                 }
             }
    -        
    +    }
    +    
    +    public ServerCache checkServerCache(final byte[] cacheId, ScanRanges keyRanges, final
TableRef cacheUsingTableRef,
    --- End diff --
    
    FYI, we already have a mechanism for this. If the server throws a HashJoinCacheNotFoundException,
then the client will react by sending the hash cache to the region servers that don't have
it.


---

Mime
View raw message