From dev-return-51201-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Thu Apr 26 16:53:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DD371180648 for ; Thu, 26 Apr 2018 16:53:03 +0200 (CEST) Received: (qmail 45891 invoked by uid 500); 26 Apr 2018 14:53:02 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 45880 invoked by uid 99); 26 Apr 2018 14:53:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Apr 2018 14:53:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 78A45C9D72 for ; Thu, 26 Apr 2018 14:53:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 2YBNexqac-64 for ; Thu, 26 Apr 2018 14:53:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 976405FBC5 for ; Thu, 26 Apr 2018 14:53:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0E25DE1215 for ; Thu, 26 Apr 2018 14:53:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6BEC921097 for ; Thu, 26 Apr 2018 14:53:00 +0000 (UTC) Date: Thu, 26 Apr 2018 14:53:00 +0000 (UTC) From: "Josh Elser (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-4701) Improve schema of SYSTEM.LOG table MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-4701?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 454340#comment-16454340 ]=20 Josh Elser commented on PHOENIX-4701: ------------------------------------- {quote}I think=C2=A0the best approach would be to persist our [client metri= cs|http://phoenix.apache.org/metrics.html] in the SYSTEM.LOG instead of inv= enting a new mechanism. The metrics captures all the same information as yo= ur QueryLogInfo (and much more), rolls all the information up to a single s= et of metrics for each Phoenix statement (aggregating/merging parallel scan= s, etc), and can emits a single log line (which could be written in a singl= e upsert statement) {quote} I like this idea. Trying to make the QueryLog as the source of truth for wh= at is happening in a cluster sounds great. {quote}I've attached a wip2 patch that writes using Phoenix APIs so that yo= u can have a composite row key to allow querying, use salting, have the tab= le be column encoded, and potentially add secondary indexes. {quote} Missed commenting on this the first time, but that's awesome, James! > Improve schema of SYSTEM.LOG table > ---------------------------------- > > Key: PHOENIX-4701 > URL: https://issues.apache.org/jira/browse/PHOENIX-4701 > Project: Phoenix > Issue Type: Bug > Reporter: James Taylor > Assignee: James Taylor > Priority: Major > Fix For: 4.14.0, 5.0.0 > > Attachments: PHOENIX-4701_wip1.patch, PHOENIX-4701_wip2.patch > > > If possible, the=C2=A0SYSTEM.LOG table would benefit greatly=C2=A0 (3-5x = perf gain) from being declared as immutable with a column encoding of 1 byt= e and a storage format of=C2=A0SINGLE_CELL_ARRAY_WITH_OFFSETS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)