From dev-return-50854-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Thu Apr 12 09:45:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 34CB2180634 for ; Thu, 12 Apr 2018 09:45:05 +0200 (CEST) Received: (qmail 8876 invoked by uid 500); 12 Apr 2018 07:45:04 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 8860 invoked by uid 99); 12 Apr 2018 07:45:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Apr 2018 07:45:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 8AB29C00A6 for ; Thu, 12 Apr 2018 07:45:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id YAFchmz0bttE for ; Thu, 12 Apr 2018 07:45:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 62F235F47D for ; Thu, 12 Apr 2018 07:45:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9D995E083A for ; Thu, 12 Apr 2018 07:45:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 29F5E241C4 for ; Thu, 12 Apr 2018 07:45:00 +0000 (UTC) Date: Thu, 12 Apr 2018 07:45:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-4575) Phoenix metadata KEEP_DELETED_CELLS and VERSIONS should be property driven MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-4575?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 435073#comment-16435073 ]=20 ASF GitHub Bot commented on PHOENIX-4575: ----------------------------------------- Github user ChinmaySKulkarni commented on the issue: https://github.com/apache/phoenix/pull/297 =20 @JamesRTaylor please review. Thanks @mujtabachohan for your initial pat= ches.=20 =20 - Added nit changes as suggested by James on JIRA - Rebased with master - @ankitsinghal please check that this does not break anything related = to your recent contributions corresponding to Query Log [PHOENIX-2715](htt= ps://issues.apache.org/jira/browse/PHOENIX-2715).=20 Changes are made to SYSLOG ddl statement. "KEEP_DELETED_CELLS" is by de= fault false now (before the default value was true). - Ran all UTs in the that are part of PHOENIX-2715 and ran UTs that are= relevant to sys table creation and upgrade -> All passed. > Phoenix metadata KEEP_DELETED_CELLS and VERSIONS should be property drive= n > -------------------------------------------------------------------------= - > > Key: PHOENIX-4575 > URL: https://issues.apache.org/jira/browse/PHOENIX-4575 > Project: Phoenix > Issue Type: New Feature > Reporter: Mujtaba Chohan > Assignee: Chinmay Kulkarni > Priority: Major > Attachments: PHOENIX-4575.patch, PHOENIX-4575_v2.patch > > > This is to cater for=C2=A0circumstances where we need to alter state of K= EEP_DELETED_CELLS/VERSION on Phoenix meta tables. -- This message was sent by Atlassian JIRA (v7.6.3#76005)