From dev-return-50585-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Mon Apr 2 22:55:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 047E0180627 for ; Mon, 2 Apr 2018 22:55:03 +0200 (CEST) Received: (qmail 14209 invoked by uid 500); 2 Apr 2018 20:55:03 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 14197 invoked by uid 99); 2 Apr 2018 20:55:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Apr 2018 20:55:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 7C6A118048D for ; Mon, 2 Apr 2018 20:55:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id ViATcbpD_-Vc for ; Mon, 2 Apr 2018 20:55:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 20E0B5F47E for ; Mon, 2 Apr 2018 20:55:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5ACADE00A6 for ; Mon, 2 Apr 2018 20:55:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 29AD42560F for ; Mon, 2 Apr 2018 20:55:00 +0000 (UTC) Date: Mon, 2 Apr 2018 20:55:00 +0000 (UTC) From: "Andrew Purtell (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-2715) Query Log MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423121#comment-16423121 ] Andrew Purtell commented on PHOENIX-2715: ----------------------------------------- Since my query is being ignored, I am -1 on this patch until we discuss it. This is a binding veto. Please respond: {quote}Is it possible to set a flag or a configuration variable so bind parameter logging can be left out? {quote} Reason I ask is the query log feature will otherwise not be useful in many environments with compliance requirements for personally identifiable information (commonly abbreviated as PII). Assuming a coder can isolate PII to bind variables, which is a reasonable tradeoff, It doesn't seem hard to do this. So why not at least consider it? Seems easy to make logging of bind parameter information configurable. > Query Log > --------- > > Key: PHOENIX-2715 > URL: https://issues.apache.org/jira/browse/PHOENIX-2715 > Project: Phoenix > Issue Type: New Feature > Reporter: Nick Dimiduk > Assignee: Ankit Singhal > Priority: Major > Attachments: PHOENIX-2715.patch, PHOENIX-2715_master.patch > > > One useful feature of other database systems is the query log. It allows the DBA to review the queries run, who's run them, time taken, &c. This serves both as an audit and also as a source of "ground truth" for performance optimization. For instance, which columns should be indexed. It may also serve as the foundation for automated performance recommendations/actions. > What queries are being run is the first piece. Have this data tied into tracing results and perhaps client-side metrics (PHOENIX-1819) becomes very useful. > This might take the form of clients writing data to a new system table, but other implementation suggestions are welcome. -- This message was sent by Atlassian JIRA (v7.6.3#76005)