phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vincent Poon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4682) UngroupedAggregateRegionObserver preCompactScannerOpen hook should not throw exceptions
Date Mon, 02 Apr 2018 20:47:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423112#comment-16423112
] 

Vincent Poon commented on PHOENIX-4682:
---------------------------------------

[~jamestaylor] thanks for the review.  I only ignore SYSTEM.CATALOG for the index disabled
case, not stats.  

I think we need to catch Exception there and not just TableNotFoundException, because we don't
want any other exception (e.g. rpc timeout, etc) to block the compaction.  I just do a special
case for TableNotFound because that is somewhat expected and doesn't need error level logging.

> UngroupedAggregateRegionObserver preCompactScannerOpen hook should not throw exceptions
> ---------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-4682
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4682
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.13.0
>            Reporter: Vincent Poon
>            Assignee: Vincent Poon
>            Priority: Major
>         Attachments: PHOENIX-4682.master.v1.patch, PHOENIX-4682.v2.0.98.patch
>
>
> TableNotFoundException in the preCompactScannerOpen hook can lead to RS abort.
> Some tables might have the phoenix coprocessor loaded but not be actual Phoenix tables
(i.e. have a row in SYSTEM.CATALOG).  We should ignore these Exceptions instead of throwing
them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message