phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geoffrey Jacoby (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4682) UngroupedAggregateRegionObserver preCompactScannerOpen hook should not throw exceptions
Date Mon, 02 Apr 2018 17:41:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422840#comment-16422840
] 

Geoffrey Jacoby commented on PHOENIX-4682:
------------------------------------------

[~vincentpoon]- I think you should also add in a check to skip this coprocessor logic when
the major compaction is of System.Catalog itself, since the logic queries System.Catalog. 

Wrt to [~apurtell]'s comment about potentially letting an IOException through – keep in
mind that the call to PhoenixRuntime.getTableNoCache is a potentially remote call to another
RS, and at no time should a timeout or problem with that call lead to a thrown IOException
out of here if that's going to potentially kill the RS. I think the original issue title should
stand.

> UngroupedAggregateRegionObserver preCompactScannerOpen hook should not throw exceptions
> ---------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-4682
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4682
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.13.0
>            Reporter: Vincent Poon
>            Assignee: Vincent Poon
>            Priority: Major
>         Attachments: PHOENIX-4682.master.v1.patch
>
>
> TableNotFoundException in the preCompactScannerOpen hook can lead to RS abort.
> Some tables might have the phoenix coprocessor loaded but not be actual Phoenix tables
(i.e. have a row in SYSTEM.CATALOG).  We should ignore these Exceptions instead of throwing
them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message