phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4605) Support running multiple transaction providers
Date Fri, 13 Apr 2018 00:11:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436514#comment-16436514
] 

James Taylor commented on PHOENIX-4605:
---------------------------------------

Thanks for the review, [~aertoria].
{quote}Do we have a upgrade plan for people to update from older version to this version
now with sys.cata change.
{quote}
Yes - I've added this code to ConnectionQueryServicesImpl.upgradeSystemTables() which adds
the TRANSACTION_PROVIDER column to SYSTEM.CATALOG when an upgrade occurs:
{code:java}
+                if (currentServerSideTableTimeStamp < MetaDataProtocol.MIN_SYSTEM_TABLE_TIMESTAMP_4_14_0)
{
+                    metaConnection = addColumnsIfNotExists(
+                        metaConnection,
+                        PhoenixDatabaseMetaData.SYSTEM_CATALOG,
+                        MetaDataProtocol.MIN_SYSTEM_TABLE_TIMESTAMP_4_14_0,
+                        PhoenixDatabaseMetaData.TRANSACTION_PROVIDER + " "
+                                + PTinyint.INSTANCE.getSqlTypeName());
+                }
{code}
{quote}Does this feature involves the input grammar changes..i.e, let's add a Jira for instruction
if not exist yet.
{quote}
We'll definitely add documentation when support for Omid goes in. There aren't any grammar
changes, though, only a new, optional table property (TRANSACTION_PROVIDER) and some new config
parameters. By default, the behavior won't change. You'll be able to specify a config that
controls the default transaction provider or set this manually when you create a table.

> Support running multiple transaction providers
> ----------------------------------------------
>
>                 Key: PHOENIX-4605
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4605
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>            Priority: Major
>         Attachments: PHOENIX-4605_v1.patch, PHOENIX-4605_v2.patch, PHOENIX-4605_wip1.patch,
PHOENIX-4605_wip2.patch, PHOENIX_4605_wip3.patch
>
>
> We should deprecate QueryServices.DEFAULT_TABLE_ISTRANSACTIONAL_ATTRIB and instead have
a QueryServices.DEFAULT_TRANSACTION_PROVIDER now that we'll have two transaction providers:
Tephra and Omid. Along the same lines, we should add a TRANSACTION_PROVIDER column to SYSTEM.CATALOG
 and stop using the IS_TRANSACTIONAL table property. For backwards compatibility, we can assume
the provider is Tephra if the existing properties are set to true.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message